Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimizing base platform + Adding 1 extra clock + Adding vadd streaming kernels + Some optimisations #205

Merged
merged 15 commits into from
Mar 8, 2022
Merged

Conversation

BrunoVandeveldeXilinx
Copy link
Contributor

@BrunoVandeveldeXilinx BrunoVandeveldeXilinx commented Mar 8, 2022

platform:

  • Removed some ip and connections to end-up with the bare minimum base platform needed
    -> Vitis nicely adds and changes IP and connections as required depending on the added kernels and their respective clocks and resets
  • Exposed 1 extra clock via BUFG (clk_out2) next to the 4 exisiting clocks via MBUFGCE (clk_out1_o1-4)
    -> id=0 -> clk_out1_o1 -> 500MHz
    -> id=1 -> clk_out1_o2 -> 250MHz
    -> id=2 -> clk_out1_o3 -> 125MHz
    -> id=3 -> clk_out1_o4 -> 62.5MHz
    -> id=4 -> clk_out2 -> 333MHz

ip:

  • Added vadd streaming kernels: mm2s_vadd_s -> vadd_s -> s2mm_vadd_s
  • Renamed vadd to vadd_mm (vadd memory mapped kernel)

ps_apps:

  • Added vadd_s to check the vadd_s streaming kernels
  • Renamed vadd_cpp and vadd_ocl to vadd_mm_cpp and vadd_mm_ocl to check the vadd memory mapped kernel
  • Using explicit "kernel:{kernel_id}" for kernel selection
  • Streamline print out messages

vitis:

  • Added vitis/src/system.cfg as dependency for the Vitis Linker
  • Added vitis/src/ila_0_bd.cfg as dependency for the Vitis Linker when build with 'ILA_EN=1'
  • Disable ILA when building vitis with 'TARGET=hw_emu'
  • counter and subtractor kernels running @ 500MHz (id=0 -> clk_out1_o1)
  • vadd_mm (vadd memory mapped kernel) running @ 250MHz (id=1 -> clk_out1_o2)
  • mm2s_vadd_s -> vadd_s -> s2mm_vadd_s (vadd_s streaming kernels) running @ 333MHz (id=4 -> clk_out2)

general:

  • Added "make clean_vitis" to be able to clean everything (ip, ps_apps, vitis) after the (fixed) platform

@imrickysu
Copy link
Contributor

It's a big change. Please make sure you run validation properly.
Suggestion: for people who may look for the previous version, a changelog that points to the previous version may help.
I'm merging this change now. Please submit additional PR if necessary.

@imrickysu imrickysu merged commit 4d937f9 into Xilinx:2021.2 Mar 8, 2022
imrickysu pushed a commit that referenced this pull request May 6, 2022
* Updating blacklist to blocklist and whitelist to allowlist in description.json

* Updating version TO 2022.1

* Updating README 

* Updated link stage generated file to .xsa instead of .xclbin for 2022

Co-authored-by: virata <[email protected]>
imrickysu pushed a commit that referenced this pull request Nov 3, 2022
* Updating blacklist to blocklist and whitelist to allowlist in description.json

* Updating version TO 2022.1

* Updating README 

* Updated link stage generated file to .xsa instead of .xclbin for 2022

Co-authored-by: virata <[email protected]>
CRTejaswi pushed a commit to CRTejaswi/amd-vitis that referenced this pull request Oct 3, 2023
da5892c Merge pull request Xilinx#205 from liyuanz/next
8395806 update
0220993 Merge pull request Xilinx#204 from liyuanz/next
0e2f53a update

Co-authored-by: sdausr <[email protected]>
CRTejaswi pushed a commit to CRTejaswi/amd-vitis that referenced this pull request Oct 3, 2023
f56d576 Merge pull request Xilinx#211 from liyuanz/next
5d02d08 update
dce4149 Merge pull request Xilinx#209 from liyuanz/next
b595b3a add mem
af6531b Merge pull request Xilinx#207 from liyuanz/next
ed264ff Merge pull request Xilinx#208 from changg/fix_meta
769b40b fix L1 meta
556b186 delete
a65f082 update
bee5349 add mem
e99a40d Merge pull request Xilinx#206 from liyuanz/next
a3705bf add mem
21d6839 Merge pull request Xilinx#204 from changg/pr_202
7c6ba95 update
359c062 Merge pull request Xilinx#205 from changg/add_mem
730ecfb add mem and time
4c645dd update
bb62d88 update makefile
24fba4d change 2022.2_stable_latest to 2023.1_stable_latest

Co-authored-by: sdausr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants