Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

chore: migrate ci from travis to github actions #658

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Nov 3, 2020

This PR configures the github action jobs of when a pull-request created. I've written a wiki here: https://cwiki.apache.org/confluence/display/PEGASUS/Github+Actions.

In addition, since the former formatting script ./scripts/linux/run-clang-format.sh relies on git to compare if codes changed, which is unavailable on github actions, I introduce a new file run-clang-format.py copied directly from https://github.com/Sarcasm/run-clang-format.

As travis-ci is no longer used, .travis.yml is removed now.

Test load_from_private_log_test.restart_duplication2 is removed because the case fails on CI. And I found it impossible to happen. Because learner always replaces the original log dir if it learns from primary's private log.

@acelyc111
Copy link
Member

good job!

@zhangyifan27
Copy link
Contributor

zhangyifan27 commented Nov 4, 2020

I think we could run build and tests for every pull request, instead of adding a "ready-for-testing" label manually for the PR needed to test.

@neverchanje
Copy link
Contributor Author

neverchanje commented Nov 4, 2020

I think we could run build and tests for every pull request, instead of adding a "ready-for-testing" label manually for the PR needed to test.

It's for the security of our self-hosted runner. Without such restriction, anyone can submit a pull-request that will possibly attack the server. And of course, it saves the resource as well.

@neverchanje neverchanje added the ready-for-testing Indicates this PR is ready to run CI testing label Nov 4, 2020
levy5307
levy5307 previously approved these changes Nov 4, 2020
@acelyc111
Copy link
Member

I think we could run build and tests for every pull request, instead of adding a "ready-for-testing" label manually for the PR needed to test.

It's for the security of our self-hosted runner. Without such restriction, anyone can submit a pull-request that will possibly attack the server. And of course, it saves the resource as well.

I agree with @zhangyifan27 , and seems we can limit parallel jobs, https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobs

@neverchanje
Copy link
Contributor Author

I agree with @zhangyifan27 , and seems we can limit parallel jobs, https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobs

@acelyc111
We don't have parallel jobs. Jobs within the PR workflow run one by one. I guess you imply that many CI workflows could run in one runner. AFAIK, if our runner is occupied, the workflow will fallback to Github runner.

@neverchanje neverchanje removed the ready-for-testing Indicates this PR is ready to run CI testing label Nov 5, 2020
@neverchanje
Copy link
Contributor Author

@acelyc111 OK, now I removed ready-for-testing requirement for PR. Please take a look.

@acelyc111
Copy link
Member

@acelyc111 OK, now I removed ready-for-testing requirement for PR. Please take a look.

LGTM

@levy5307 levy5307 merged commit ec47b0c into XiaoMi:master Nov 5, 2020
@neverchanje neverchanje deleted the ci-fake branch November 5, 2020 04:21
zhangyifan27 pushed a commit to zhangyifan27/rdsn that referenced this pull request Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants