fix dup test

src/replica/duplication/test/load_from_private_log_test.cpp

@@ -259,7 +259,7 @@ class load_from_private_log_test : public duplication_test_base
         // log.2.xxx starts from 39100
         // log.3.xxx starts from 38200
         mutation_log_ptr mlog = create_private_log();
-        ASSERT_NE(mlog, nullptr);
+        ASSERT_NE(mlog, nullptr) << log_utils::list_files_to_string(open_log_file_map(_log_dir));
         auto files = mlog->get_log_file_map();
         ASSERT_EQ(files.size(), 2);
 

src/replica/mutation_log_replay.cpp

@@ -151,9 +151,10 @@ namespace replication {
         log_file_ptr &log = kv.second;
 
         if (log->start_offset() != end_offset) {
-            derror("offset mismatch in log file offset and global offset %" PRId64 " vs %" PRId64,
-                   log->start_offset(),
-                   end_offset);
+            derror_f("offset mismatch in log file ({}) offset and global offset: {} vs {}",
+                     log->path(),
+                     log->start_offset(),
+                     end_offset);
             return ERR_INVALID_DATA;
         }
 

src/replica/mutation_log_utils.cpp

@@ -93,6 +93,21 @@ error_s check_log_files_continuity(const std::map<int, log_file_ptr> &logs)
     return error_s::ok();
 }
 
+/*extern*/ std::string list_files_to_string(const std::map<int, log_file_ptr> &logs)
+{
+    bool first = true;
+    std::string all_log_files_str;
+    for (const auto &id_file : logs) {
+        if (!first) {
+            all_log_files_str += ", ";
+        }
+        first = false;
+        all_log_files_str +=
+            fmt::format("log.{}.{}", id_file.second->index(), id_file.second->start_offset());
+    }
+    return all_log_files_str;
+}
+
 } // namespace log_utils
 } // namespace replication
 } // namespace dsn

src/replica/mutation_log_utils.h

@@ -77,6 +77,9 @@ inline error_s check_log_files_continuity(const std::string &dir)
     return check_log_files_continuity(log_file_map) << "check_log_files_continuity(dir)";
 }
 
+//
+extern std::string list_files_to_string(const std::map<int, log_file_ptr> &logs);
+
 } // namespace log_utils
 } // namespace replication
 } // namespace dsn