Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set expire atomicly #18

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Set expire atomicly #18

merged 2 commits into from
Feb 16, 2019

Conversation

WyriHaximus
Copy link
Owner

Closes #17

@WyriHaximus WyriHaximus mentioned this pull request Feb 15, 2019
Closed
clue
clue approved these changes Feb 16, 2019
View reviewed changes
Copy link

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for the quick update! :shipit:

(The build error seems to be unrelated afaict)

@WyriHaximus
Copy link
Owner Author

What build errors? :P

@WyriHaximus WyriHaximus merged commit 519f6c2 into master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WyriHaximus @clue