-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should use atomic PSETEX instead of SET+EXPIRE/PEXPIRE #17
Comments
It should indeed! Thank you for bringing this to my attention, would you be up for creating a PR changing the behavior? |
I've spotted this during a quick project evaluation for a project I'm currently working on, so this will be of interest in the future. Expect this to take at least a couple of weeks, so let's see who's faster with filing a PR, cheers! 🥇 |
#18 is up with a fix for this 👍 🎉 |
@WyriHaximus Thanks for the quick update, LGTM! |
This project should probably use the atomic
PSETEX
command instead of two individualSET
andEXPIRE
calls:Additionally, in fact this project currently uses
EXPIRE
instead ofPEXPIRE
and as such only provides full second accuracy. It's my understanding this should probably be updated to use millisecond precision as given above.The text was updated successfully, but these errors were encountered: