-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dolphin and fish hack #799
Fix dolphin and fish hack #799
Conversation
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
WalkthroughThe changes primarily focus on improving the accuracy of conditions in the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (2)
- src/main/java/net/wurstclient/hacks/DolphinHack.java (1 hunks)
- src/main/java/net/wurstclient/hacks/FishHack.java (1 hunks)
Additional comments (Suppressed): 2
src/main/java/net/wurstclient/hacks/DolphinHack.java (1)
- 40-46: The change from
player.isWet()
toplayer.isTouchingWater()
is a good one as it ensures the hack is only activated when the player is actually in water, not just wet from rain or bubble columns. However, please verify thatplayer.isTouchingWater()
is the correct method to use and it doesn't have any unintended side effects.src/main/java/net/wurstclient/hacks/FishHack.java (1)
- 40-46: The change from
player.isWet()
toplayer.isTouchingWater()
is a good one as it ensures that the hack is only activated when the player is actually in contact with water, not just when they are in the rain or in a bubble column. This change aligns with the intended functionality of the hack. However, please verify that theisTouchingWater()
method provides the expected behavior in all scenarios, including when the player is partially submerged or touching water from the side.
Currently, dolphin and fish hack uses Entity.isWet(), which causes them to activate when the player is in rain (which is not the intended behavior of those hacks) and in a bubble column (where the hack would be ineffective anyways). Changing it to isTouchingWater() makes these hacks only activate in the correct scenario.
Summary by CodeRabbit