-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix X-Ray brightness reset #850
Fix X-Ray brightness reset #850
Conversation
WalkthroughWalkthroughThe updates in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- src/main/java/net/wurstclient/hacks/FullbrightHack.java (1 hunks)
- src/main/java/net/wurstclient/hacks/XRayHack.java (1 hunks)
Additional comments: 2
src/main/java/net/wurstclient/hacks/FullbrightHack.java (2)
166-169: The method
isGammaOption()
has been added as a public method. Verify if this method is intended to be part of the public API or if it should be private.168-168: The implementation of
isGammaOption()
correctly checks if the Fullbright mod's current method is set to gamma.
X-Ray will now reset the brightness on disable if the fullbright mod is disabled and when the fullbright mod is enabled with night vision mode.
According to the Fullbright hack, if the gamma option is not chosen, the brightness is set to the default value indicated by the
defaultGamma
slider. It makes sense then to reset the brightness if fullbright is on but night vision is enabled.