Add support for COUNT queries and NUMBER and BOOLEAN property mapping #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelhoral
force-pushed
the
feat-query-count
branch
from
4e6d31b to
083f23d
Compare
Closed
pavelhoral
force-pushed
the
feat-query-count
branch
4 times, most recently
from
7248599 to
2d61427
Compare
pavelhoral
changed the title
pavelhoral
changed the title
pavelhoral
force-pushed
the
feat-query-count
branch
from
5c6579f to
ab36537
Compare
karelmaxa
requested changes
Feb 6, 2024
openidm-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/Activator.java
Outdated
Show resolved
Hide resolved
openidm-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/JDBCRepoService.java
Outdated
Show resolved
Hide resolved
openidm-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/JDBCRepoService.java
Outdated
Show resolved
Hide resolved
openidm-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/JDBCRepoService.java
Outdated
Show resolved
Hide resolved
openidm-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/JDBCRepoService.java
Outdated
Show resolved
Hide resolved
...repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/handler/MappedTableHandler.java
Outdated
Show resolved
Hide resolved
...-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/mapper/MappedResultMapper.java
Outdated
Show resolved
Hide resolved
...dm-repo-jdbc/src/main/java/org/forgerock/openidm/repo/jdbc/impl/query/TableQueryHandler.java
Show resolved
Hide resolved
...dbc/src/test/java/org/forgerock/openidm/repo/jdbc/impl/handler/AbstractTableHandlerTest.java
Outdated
Show resolved
Hide resolved
openidm-repo/src/main/java/org/forgerock/openidm/repo/util/TokenHandler.java
Outdated
Show resolved
Hide resolved
pavelhoral
force-pushed
the
feat-query-count
branch
from
ab36537 to
50ab56c
Compare
This commit adds new implementation of many openidm-repo-jdbc components. Most components ertr written from scratch with only a few pieces directly taken from the original code. The overall module logic stays the same and the overall comoponent structure as well. To make sure the DB integration works and the refactor does not introduce any inconsistency a testcontainer integration tests are added. These tests can be run on the legacy components as well as the new components. This commit intentionally leaves both implementations so that it is possible to return to this state and recheck legacy behavior.
pavelhoral
force-pushed
the
feat-query-count
branch
from
50ab56c to
c0fe7d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes made to the openidm-repo-jdbc module:
The refactor is split into multiple commits:
JDBCRepoServiceuse newly written componentsAs I was on my Windows machine one of the commit also fixes Windows build. All these commits have to be kept separate (so no squashing). I want to be able to get back to the legacy implementation and run the tests again if we find out something is missing from the refactor or that something behaves a bit differently.
Few notes on compatibility: