Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL integration tests #115

Closed
krystofNovotny opened this issue Oct 8, 2021 · 2 comments
Closed

SQL integration tests #115

krystofNovotny opened this issue Oct 8, 2021 · 2 comments
Assignees
@pavelhoral
Labels
enhancement

Comments

@krystofNovotny
Copy link

Currently, there are no integration tests for tableHandlers making it harder to change or add new queries.

Solution for this issue is to:

  • introduce testcontainers as test dependency
  • write integration test for MappedTableHandler and GenericTableHandler and make sure it passes for all supported databases
@pavelhoral pavelhoral self-assigned this Jan 24, 2024
@pavelhoral
Copy link
Member

I am in the middle of refactoring openidm-jdbc-repo module and I am playing with testcontainers right now. I guess once I have PR ready this feature request will be solved by it as well.

@pavelhoral pavelhoral mentioned this issue Feb 4, 2024
Merged
@pavelhoral
Copy link
Member

Testcontainers integration testing is included in #169.

@pavelhoral pavelhoral mentioned this issue Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelhoral pavelhoral

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavelhoral @krystofNovotny