Make top margin of sidebar container configurable via theme.json #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
added
Redesign
adamwoodnz
commented
Oct 19, 2023
|
|
||
| /* Set up the custom properties. These can be overridden by settings in theme.json. */ | ||
| :where(body) { | ||
| --wp--custom--wporg-sidebar-container--spacing--margin--top: var(--wp--preset--spacing--edge-space); |
There was a problem hiding this comment.
Default value set to the existing value so that the Documentation site doesn't require any changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #483
Makes the top margin of the sidebar container configurable, so that it can be changed for the redesigned Developer site.
Keeps the existing value as the default so that the Documentation site isn't affected.
Testing
Easiest to use the Developer PR, see testing instructions there.