-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update handbook layout #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
changed the base branch from
trunk
to
update/267-search-results-update
October 6, 2023 03:51
Closed
adamwoodnz
force-pushed
the
update/266-coding-standards
branch
from
October 9, 2023 22:04
8c57dfd
to
6197870
Compare
adamwoodnz
commented
Oct 9, 2023
adamwoodnz
force-pushed
the
update/266-coding-standards
branch
from
October 9, 2023 22:18
6197870
to
14cbd13
Compare
adamwoodnz
force-pushed
the
update/266-coding-standards
branch
2 times, most recently
from
October 19, 2023 03:24
d13ec6b
to
028422c
Compare
adamwoodnz
force-pushed
the
update/266-coding-standards
branch
from
October 19, 2023 03:49
028422c
to
391e9c8
Compare
I think this captures the conversations we had with @ndiego and @justintadlock in the Figma file, so looks good to me, but here just a ping in their direction. |
The change looks fine to me 👌 |
Version 2 required to disable old ToC using `wporg_handbook_toc_should_add_toc`
adamwoodnz
force-pushed
the
update/266-coding-standards
branch
from
October 24, 2023 03:11
e29b2c0
to
cdd9390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266
Depends on WordPress/wporg-mu-plugins#484 and WordPress/wporg-parent-2021#114
Widens the layout, adjusts sidebar position and pagination width, adds table styles.
NOTE: Does not include the Chapter list update
Screenshots
Full page, monitor size, with tables
Testing