Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handbook layout #299

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Update handbook layout #299

merged 9 commits into from
Oct 26, 2023

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Oct 6, 2023

Closes #266
Depends on WordPress/wporg-mu-plugins#484 and WordPress/wporg-parent-2021#114

Widens the layout, adjusts sidebar position and pagination width, adds table styles.

NOTE: Does not include the Chapter list update

Screenshots

Full page, monitor size, with tables

localhost_8888_block-editor_reference-guides_theme-json-reference_theme-json-living_(Monitor)

Monitor Desktop Tablet Mobile
localhost_8888_coding-standards_inline-documentation-standards_javascript_(Monitor) localhost_8888_coding-standards_inline-documentation-standards_javascript_(Desktop) localhost_8888_coding-standards_inline-documentation-standards_javascript_(iPad) localhost_8888_coding-standards_inline-documentation-standards_javascript_(Samsung Galaxy S20 Ultra)

Testing

  1. Ensure your mu-plugins and parent branches match the dependencies listed above
  2. Try loading all the handbooks and check layout, there is a list in functions.php
  3. The layout goes wider than any of the other templates; the center column should keep expanding until the window reaches 1920px wide.
  4. Check handbooks with long ToCs that fit in the viewport and become sticky on scroll, they should not overlap the pagination at the bottom.
  5. Check the table styles, eg. theme-json-living, identified in Table styles missing for in-content tables. #235

@adamwoodnz adamwoodnz changed the base branch from trunk to update/267-search-results-update October 6, 2023 03:51
@adamwoodnz adamwoodnz self-assigned this Oct 6, 2023
@adamwoodnz adamwoodnz added this to the MVP milestone Oct 6, 2023
@adamwoodnz adamwoodnz linked an issue Oct 8, 2023 that may be closed by this pull request
Base automatically changed from update/267-search-results-update to trunk October 9, 2023 21:59
@adamwoodnz adamwoodnz force-pushed the update/266-coding-standards branch from 8c57dfd to 6197870 Compare October 9, 2023 22:04
@adamwoodnz adamwoodnz force-pushed the update/266-coding-standards branch from 6197870 to 14cbd13 Compare October 9, 2023 22:18
@adamwoodnz adamwoodnz force-pushed the update/266-coding-standards branch 2 times, most recently from d13ec6b to 028422c Compare October 19, 2023 03:24
@adamwoodnz adamwoodnz force-pushed the update/266-coding-standards branch from 028422c to 391e9c8 Compare October 19, 2023 03:49
@adamwoodnz adamwoodnz marked this pull request as ready for review October 19, 2023 22:44
@adamwoodnz adamwoodnz requested review from StevenDufresne, renintw and a team October 19, 2023 22:44
@jasmussen
Copy link
Collaborator

I think this captures the conversations we had with @ndiego and @justintadlock in the Figma file, so looks good to me, but here just a ping in their direction.

@fcoveram
Copy link

The change looks fine to me 👌

@adamwoodnz adamwoodnz force-pushed the update/266-coding-standards branch from e29b2c0 to cdd9390 Compare October 24, 2023 03:11
@adamwoodnz adamwoodnz merged commit 905ae78 into trunk Oct 26, 2023
1 check passed
@adamwoodnz adamwoodnz deleted the update/266-coding-standards branch October 26, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding standards update
3 participants