The ::class constant #104
Merged
The ::class constant #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingo-d
force-pushed
the
class-constant
branch
from
d63cd79 to
098fe20
Compare
Merged
jrfnl
reviewed
Aug 20, 2022
|
Needs a rebase, but otherwise okay. |
Co-authored-by: Juliette <[email protected]>
dingo-d
force-pushed
the
class-constant
branch
from
877a384 to
bad2c6e
Compare
jrfnl
approved these changes
Aug 28, 2022
There was a problem hiding this comment.
LGTM
Merging this now as @GaryJones is AFK for the next few weeks. If needs be, additional textual tweaks can still be made in a follow up commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #102. Once that is merged, this PR should be rebased to the master branch.
The PR adds rules about the
::classconstant and is the continuation of the additions of 'modern' PHP code in the WordPress PHP Coding Standards handbook based on the make post by Juliette Reinders Folmer.