-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type declarations #102
Type declarations #102
Conversation
I've added all the types currently available that cannot be used in core (still), but since the wording in the alert now excludes core I've reworded the phrase I'm open to rewording these statements if they read weird in any way. |
b3609ef
to
7193559
Compare
7193559
to
37b7522
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gone through it with a fine toothcomb....
ac8aa06
to
910374c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments + the remark about the order of information.
910374c
to
f1bd412
Compare
Co-authored-by: Juliette <[email protected]> Co-authored-by: Gary Jones <[email protected]>
f1bd412
to
d24ab04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. There is a stray space in line 425 "code[space][space]new to Core", which I will remove before merging.
Merging this now as @GaryJones is AFK for the next few weeks. If needs be, additional textual tweaks can still be made in a follow up commit.
This PR depends on #101. Once that is merged, this PR should be rebased to the master branch.
The PR adds rules about the type declaration rules and is the continuation of the additions of 'modern' PHP code in the WordPress PHP Coding Standards handbook based on the make post by Juliette Reinders Folmer.