Meta: Remove the automated formatting check #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The automated formatting check requires frequent revisions over minor issues like an extra space in a markdown document, without offering much in return. An occasional difference in formatting style is fine as long as it self-corrects in the long run – and that's what the pre-commit formatting check should take care of. This is an experimental change and we may have to roll it back or course-correct if I'm wrong about the self-correcting aspect and the overall formatting gets wildly out of hand. That being said, let's give it a try and see how it works.
adamziel
force-pushed
the
disable-ci-lint-check
branch
from
af5a53c to
5e0f946
Compare
adamziel
added
[Type] Enhancement
danielbachhuber
added a commit
to WordPress/playground-tools
that referenced
this pull request
Jun 7, 2023
## What? Copies CI tooling improvements from WordPress Playground, specifically: * WordPress/wordpress-playground#494 * WordPress/wordpress-playground#496 ## Why? * We should keep CI as consistent as possible between the two repositories. * It's nice to have linting and testing split into separate jobs, so it's easier to see what fails. * We'll benefit from a slight performance boost. ## Testing Instructions 1. Verify that all tests are run and pass as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated formatting check requires frequent revisions over minor issues like an extra space in a markdown document, without offering much in return. An occasional difference in formatting style is fine as long as it self-corrects in the long run – and that's what the pre-commit formatting check should take care of.
This is an experimental change and we may have to roll it back or course-correct if I'm wrong about the self-correcting aspect and the overall formatting gets wildly out of hand.
That being said, let's give it a try and see how it works.
Testing Instructions
Confirm the CI workflow doesn't check code formatting