Meta: Inline CI linting with cache warmup #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
danielbachhuber
added a commit
to WordPress/playground-tools
that referenced
this pull request
Jun 7, 2023
## What? Copies CI tooling improvements from WordPress Playground, specifically: * WordPress/wordpress-playground#494 * WordPress/wordpress-playground#496 ## Why? * We should keep CI as consistent as possible between the two repositories. * It's nice to have linting and testing split into separate jobs, so it's easier to see what fails. * We'll benefit from a slight performance boost. ## Testing Instructions 1. Verify that all tests are run and pass as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Inlines linting and typechecking with the initial cache warmup in the GitHub workflow file. The linting tasks take ~5s to complete and separating them means they actually take longer to continue because a separate step would require ~25s just to run
git cloneand restorenode_modulesfrom cache.Testing Instructions
Confirm the CI checks under this PR are green