Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Test Tools: Pin Gutenberg version to 19.7.0 #8008

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Dec 16, 2024

WordPress/gutenberg#67117 bumped the Gutenberg plugin's minimum required WordPress version to 6.6. That change was first shipped as part of GB 19.8.0 (see WordPress/gutenberg@58e2d4b).

This means that GB 19.7.0 (i.e. the last release from the 19.7.x series) was the last version that supported WordPress 6.5.

As a consequence, the end-to-end tests on Core's 6.5 branch need to be updated to pin the Gutenberg version to that version, so that E2E test will use that version (rather than a newer one) for testing Core's compatibility with the Gutenberg plugin.

See https://core.trac.wordpress.org/changeset/59221 for the analogue change for the 6.4 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/62488


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham requested a review from desrosj December 16, 2024 13:40
@ockham ockham self-assigned this Dec 16, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bernhard-reiter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up, @ockham!

@desrosj
Copy link
Contributor

desrosj commented Dec 16, 2024

Merged in https://core.trac.wordpress.org/changeset/59518.

@desrosj desrosj closed this Dec 16, 2024
@ockham
Copy link
Contributor Author

ockham commented Dec 16, 2024

Thank you for merging, @desrosj! 😄

@ockham ockham deleted the update/pin-gutenberg-version-for-wordpress-6-5 branch December 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants