-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: Bump minimum required WordPress version to 6.6 #67117
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Shouldn't we remove first (or at the same PR) the compat layer for 6.6? |
Sure! I see that's what you did for 6.5 (#64096 before #64126). Looks like you also had to remove the 6.4 compat layer in #64096 since I didn't do that in #60780 🙈 So it's probably a good idea to do it at once. I'll push a commit 👍 |
Thanks @ockham I smoke tested the site editor and the revisions controller stuff in particular. From my perspective LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke-tested editors and everything looks to be working correctly.
No PHP errors or warnings in logs.
Flaky tests detected in f602432. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11929986618
|
Just a heads up that when we bump minimum version requirements, we do need to make a Core SVN change to pin the last compatible version of the Gutenberg plugin in the E2E test workflow for any branch losing support. I've gone and opened #67167 to add this to the documentation, and Core-62488 to make this change once 19.8 enters RC phase. |
TIL 😅 Thank you @desrosj! |
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Similar to #64126.
Bumps the "Required WP version" field to 6.6, and the "Tested up to" field to 6.7. It also updates the performance test base hash.
Why?
To reflect the current WP version, and update the minimum required version to the previous one.
I'd also like to unblock #64676 😬
How?
See https://developer.wordpress.org/block-editor/explanations/architecture/performance/#update-the-reference-commit
Testing Instructions