Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Sync packages to include gutenberg_ to wp_ prefix change #4748

Closed

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Jun 28, 2023

To include this fix.

Trac ticket: https://core.trac.wordpress.org/ticket/58651


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

package.json Outdated Show resolved Hide resolved
@ockham
Copy link
Contributor Author

ockham commented Jun 28, 2023

I think I need to temporarily remove @wordpress/nux before running the sync script (npm run sync-gutenberg-packages -- --dist-tag=wp-6.3) (and then add it back) to get all the right version updates. Will do that now.

@ockham ockham force-pushed the update/sync-packages-wp-6-3-beta-1-gutenberg-prefix branch from 695818c to 95f5aa3 Compare June 28, 2023 22:06
@ockham
Copy link
Contributor Author

ockham commented Jun 28, 2023

I think I need to temporarily remove @wordpress/nux before running the sync script (npm run sync-gutenberg-packages -- --dist-tag=wp-6.3) (and then add it back) to get all the right version updates. Will do that now.

Done.

@ockham ockham marked this pull request as ready for review June 28, 2023 22:07
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me

@sabernhardt
Copy link

https://core.trac.wordpress.org/ticket/58651

Copy link
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Ship it.

@spacedmonkey
Copy link
Member

@ockham CI seems to be failing :(

@ockham
Copy link
Contributor Author

ockham commented Jun 28, 2023

@ockham CI seems to be failing :(

Dang. I think I need to npm run build:dev to update the script loader file...

@ockham
Copy link
Contributor Author

ockham commented Jun 28, 2023

Committed to Core trunk in https://core.trac.wordpress.org/changeset/56098.

@ockham ockham closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants