Block Supports: Change prefix in gutenberg_apply_colors_support to wp_ in dynamic blocks #51989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcgill
approved these changes
Jun 27, 2023
|
Thank you, folks! 🚀 |
|
Size Change: 0 B Total Size: 1.45 MB ℹ️ View Unchanged
|
|
I believe that e2e tests are failing because they we use WordPress I'll quickly run them locally (with a working -- if not totally up-to-date -- WordPress) to verify. If they pass, I'm inclined to land this PR so I'll be able to publish another round of npms that includes this change, and to update |
|
Since tests are also failing locally (which might be inconsequential), I'm leaning towards skipping this for WP 6.3 Beta 1 and getting it into Beta 2 instead. I've now merged WordPress/wordpress-develop#4722 which should fix Core |
|
Flaky tests detected in fc0decb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5401763998
|
ramonjd
added
Backport to WP 6.7 Beta/RC
…_ in dynamic blocks
ockham
force-pushed
the
rename/gutenberg-apply-colors-support
branch
from
2097de7
to
fc0decb
Compare
|
The remaining e2e failure is present on a number of other recent commits to (It's a number of |
felixarntz
approved these changes
Jun 28, 2023
|
This PR is blocked until E2E test are passing. I am re-running now. |
|
Cherry-picked to |
|
@ramonjd @tellthemachines I guess we also might want this in a GB 16.1.x point release? |
|
@ockham Thanks for the ping.
As long as WordPress core is not referring to it, it will be fine. Probably not ideal from a consistency point of view however. This consistency, of course, will be there on the next release of Gutenberg (16.2) thanks to this PR's changes. It's totally feasible for PHP block code that lives only in the plugin to refer to Only during syncing Gutenberg with Core do we need to make sure these don't creep into the Core code. We all know how well that works out :) There some initiatives under way to prevent such situations, e.g., https://core.trac.wordpress.org/ticket/56794 |
tellthemachines
removed
Backport to WP 6.7 Beta/RC
This was referenced Jul 12, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…_ in dynamic blocks (WordPress#51989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the Navigation Submenu dynamic block, rename
gutenberg_apply_colors_supporttowp_apply_colors_support, and add the latter to the list of function calls that are rewritten during block build time.Why?
For the Core merge, see WordPress/wordpress-develop#4722 (comment).
How?
Uses the existing mechanism in Webpack to rename functions during block build. See e.g.
wp_get_typography_font_size_value/gutenberg_get_typography_font_size_valuefor precedent.Testing Instructions
Verify that "Color" block supports still works.