Add filters for email token and backup code length #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374.
Replaces #419.
What?
Implements two new filters:
two_factor_token_lengthfilter overrides the default 8 character count for email tokens. Note that I didn't includeemailanywhere to match the existingtwo_factor_token_ttlfilter which applies to email tokens.two_factor_backup_code_lengthfilter overrides the default 8 character count for backup codes. Providers theWP_Userof the associated user as the second argument.Why?
Users might want to increase this.
How?
Testing Instructions
Screenshots or screencast
Changelog Entry
Added - Introduce
two_factor_token_lengthandtwo_factor_backup_code_lengthfilters for adjusting the length of the respective tokens.