Add filter two_factor_email_token_length #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of the email token (code) can be set with filter two_factor_email_token_length The default is 8, like before
|
Per yesterday's bug scrub, @georgestephanis is going to give this a review but there's some minor whitespace tweaks around line 80 inside the function call and also not entirely certain abstracting this into its own method is required, as it's not used anywhere else, though @georgestephanis is definitely in favor of the concept. |
|
@kasparsd any code review feedback on the approach here? |
|
The formatting fixes are addressed in #653 which also adds similar filter to backup codes. |
|
Thank you very much for implementing this feature in #653 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length of the email token (code) can be set with filter two_factor_email_token_length
The default is 8, like before