Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/594 - Prefer "require_once" in a few spots. #595

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

JJJ
Copy link
Contributor

@JJJ JJJ commented Feb 29, 2024

What?

Using "require_once" everywhere, replacing a few inconsistent "require" and "include_once" usages

Why?

I'm being a silly and manually including a file in another plugin

How?

By using require_once, we'll all get to bypass some PHP warnings that don't appear to be intended behavior as-is

Testing Instructions

Install the latest Github master branch of the WP User Profiles plugin, navigate to your Admin Area Profile page, and visit the "Account" tab. Once there, you'll see a glorious warning because we're already (manually) including one of the files in this plugin

Changelog Entry

Prefer "require_once" in a few spots.

This change prevents unintended PHP warnings when silly JJJ people are doing silly JJJ things.

Fixes #594.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This change prevents unintended PHP warnings when silly JJJ people are doing silly JJJ things.

Fixes WordPress#594.
Copy link
Collaborator

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@kasparsd kasparsd merged commit 7e0d337 into WordPress:master Feb 29, 2024
1 check passed
@JJJ JJJ deleted the issue-594 branch February 29, 2024 13:31
@jeffpaul jeffpaul added this to the 0.9.0 milestone Feb 29, 2024
@kasparsd kasparsd mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer "require_once" over "require" in a few spots
3 participants