Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer "require_once" over "require" in a few spots #594

Closed
JJJ opened this issue Feb 29, 2024 · 0 comments · Fixed by #595
Closed

Prefer "require_once" over "require" in a few spots #594

JJJ opened this issue Feb 29, 2024 · 0 comments · Fixed by #595
Milestone

Comments

@JJJ
Copy link
Contributor

JJJ commented Feb 29, 2024

Is your enhancement related to a problem? Please describe.

We're manually including a file from the Two-Factor plugin in my WP User Profiles plugin, and it just-so-happens to be one of the few that are not require_onceed.

Proposed Solution

require_once is already predominantly used here, so it won't hurt to be consistent and match-up the stragglers.

Designs

None

Describe alternatives you've considered

We tried to work-around manually including Two-Factor files, but due to the amount of CSS & JS that is included and it being under-construction, it doesn't seem right to package copies of it all inside the WP User Profiles plugin (just to work around a notice).

Please confirm that you have searched existing issues in this repository.

Yes

JJJ added a commit to JJJ/two-factor that referenced this issue Feb 29, 2024
This change prevents unintended PHP warnings when silly JJJ people are doing silly JJJ things.

Fixes WordPress#594.
@jeffpaul jeffpaul added this to the 0.9.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants