Add express to dependencies; Update follow-redirects to newest version #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is the second part of solving:
The first part is WordPress/wordpress-playground#1218. (php-wasm/node: Update express to newest version, and move it to devDependencies)
Why?
The first part of the solution is in the Playground project, which updates
express
and moves it todevDependencies
since it's only used for tests in that project.As a result,
express
will no longer be installed when@php-wasm/node
is installed. Sowp-now
needs to declareexpress
as a dependency.How?
express
todependencies
follow-redirects
to newest1.15.6
These together with WordPress/wordpress-playground#1218 will resolve the original issue #224, which should eliminate all npm audit warnings.
Testing Instructions
Currently
npm run test
fails with an unrelated issue, as can be seen in another PR's CI test run. https://github.com/WordPress/playground-tools/actions/runs/8616282863/job/23614052137?pr=223#step:4:49 ("RuntimeError: memory access out of bounds") That seems have been caused by commit 133029c.