Skip to content

Commit

Permalink
Add express to dependencies; Update follow-redirects to newest version (
Browse files Browse the repository at this point in the history
#225)

This is the second part of solving:

- #224 

The first part is WordPress/wordpress-playground#1218. (php-wasm/node:
Update express to newest version, and move it to devDependencies)

## Why?

The first part of the solution is in the Playground project, which
updates `express` and moves it to `devDependencies` since it's only used
for tests in that project.

As a result, `express` will no longer be installed when `@php-wasm/node`
is installed. So `wp-now` needs to declare `express` as a dependency.

## How?

- Add `express` to `dependencies`
- Update `follow-redirects` to newest `1.15.6`

These together with WordPress/wordpress-playground#1218 will resolve the
original issue #224, which should eliminate all npm audit warnings.

## Testing Instructions

Currently `npm run test` fails with an unrelated issue, as can be seen
in another PR's CI test run.
https://github.com/WordPress/playground-tools/actions/runs/8616282863/job/23614052137?pr=223#step:4:49
("RuntimeError: memory access out of bounds") That seems have been
caused by commit
[133029c](133029c).
  • Loading branch information
eliot-akira authored Apr 12, 2024
1 parent 03b2548 commit d78c044
Show file tree
Hide file tree
Showing 2 changed files with 165 additions and 21 deletions.
183 changes: 163 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@
"compressible": "2.0.18",
"compression": "1.7.4",
"copy-webpack-plugin": "11.0.0",
"express": "4.19.2",
"express-fileupload": "1.4.0",
"file-saver": "^2.0.5",
"follow-redirects": "1.15.2",
"follow-redirects": "1.15.6",
"fs-extra": "11.1.1",
"hpagent": "1.2.0",
"react": "^18.2.0",
Expand Down

0 comments on commit d78c044

Please sign in to comment.