Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter: Fix small style issue #9494

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Inserter: Fix small style issue #9494

merged 2 commits into from
Aug 31, 2018

Conversation

youknowriad
Copy link
Contributor

closes #9491 Regression introduces in #9310

This PR fixes the small issue where the border bottom of the block list was not properly displayed because the block list was containing exclusively floated elements, so its height doesn't fit its content.

Testing instructions

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 31, 2018
@youknowriad youknowriad added this to the 3.7 milestone Aug 31, 2018
@youknowriad youknowriad self-assigned this Aug 31, 2018
@youknowriad youknowriad requested review from jasmussen and a team August 31, 2018 09:07
jasmussen
jasmussen requested changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes an issue with focus styles:

screen shot 2018-08-31 at 11 19 04

Let me see if I can push a fix for that.

@jasmussen jasmussen self-requested a review August 31, 2018 09:22
jasmussen
jasmussen approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the focus style fixed, this is good to go. Thanks Riad.

@gziolo
Copy link
Member

gziolo commented Aug 31, 2018

I'm seeing the same issue.

@jasmussen
Copy link
Contributor

@gziolo Do you see the issue after pulling? I pushed a fix.

@youknowriad
Copy link
Contributor Author

youknowriad commented Aug 31, 2018 •
edited
Loading

Another approach (instead of padding) would be to avoid overflow: hidden and adding a <li className="clearfix"></li> at the end of the block list container, not certain if it's any better.

@gziolo
Copy link
Member

gziolo commented Aug 31, 2018

works properly with the last commit 👍

@youknowriad youknowriad merged commit 7a6124e into master Aug 31, 2018
@youknowriad youknowriad deleted the fix/inserter-border branch August 31, 2018 09:38
@jasmussen
Copy link
Contributor

I would love to avoid any clearfixes that involve empty divs or classnames :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@jasmussen jasmussen jasmussen approved these changes

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.

3.7 block inserter styling broken
3 participants
@youknowriad @gziolo @jasmussen