Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish region focus style #7459

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Polish region focus style #7459

merged 2 commits into from
Jun 22, 2018

Conversation

jasmussen
Copy link
Contributor

This is a small βœ‹ Friday PR! 🀚

It does one thing β€” adds a little animation flourish to the focus style we show when you navigate between regions. Press Ctrl + [the key below escape] to invoke this. Here's how it looks:

regionfocus

Sorry for the low-quality GIF, it's barely perceptible. But what happens is that the blue focus outline animates from 0px width to 4px width with a speed of .1s.

This is a small βœ‹ Friday PR! 🀚

It does one thing β€” adds a little animation flourish to the focus style we show when you navigate between regions. Press Ctrl + [the key below escape] to invoke this. Here's how it looks:
@jasmussen jasmussen added this to the 3.2 milestone Jun 22, 2018
@jasmussen jasmussen self-assigned this Jun 22, 2018
@jasmussen jasmussen requested a review from a team June 22, 2018 08:13
@gziolo gziolo added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 22, 2018
@gziolo gziolo requested a review from jorgefilipecosta June 22, 2018 08:23
}
}

@mixin region_focus( $speed: 0.2s ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe editor_region_focus?

@jasmussen jasmussen merged commit c4b1362 into master Jun 22, 2018
@jasmussen jasmussen deleted the polish/region-focus branch June 22, 2018 09:55
oxyc added a commit to generoi/gutenberg that referenced this pull request Jun 26, 2018
* 'master' of https://github.com/WordPress/gutenberg: (69 commits)
  fix: Show permalink editor in editor (WordPress#7494)
  Fix text wrapping in Firefox. (WordPress#7472)
  Try another approach to fixing the sibling inserter in Firefox (WordPress#7530)
  fix: Improve "add block" text in NUX onboarding (WordPress#7511)
  Implement core style of including revisions data on Post response (WordPress#7495)
  Testing: Add e2e test for PluginPostStatusInfo (WordPress#7284)
  Add end 2 end test for sidebar behaviours on mobile and desktop. (WordPress#6877)
  Only save metaboxes when it's not an autosave (WordPress#7502)
  Fix broken links in documentation (WordPress#7532)
  Remove post type 'viewable' compatibility shim (WordPress#7496)
  Fix typo. (WordPress#7528)
  Blocks: Remove wrapping div from paragraph block (WordPress#7477)
  fix: change import for InnerBlocks (WordPress#7484)
  Polish library just a teeeeensy bit (WordPress#7522)
  feat: Add snapshot update script (WordPress#7514)
  Display server error message when one exists (WordPress#7434)
  Fix issues with gallery in IE11. (WordPress#7465)
  Polish region focus style (WordPress#7459)
  Fix IE11 formatting toolbar visibility (WordPress#7413)
  Update plugin version to 3.1. (WordPress#7402)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants