Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Bindings: Remove client core sources registration in widgets #67349

Merged
merged 2 commits into from
Nov 28, 2024
+0 −14
Merged

Block Bindings: Remove client core sources registration in widgets #67349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
566c93f
Remove client core sources registration in widgets
SantosGuillamot Nov 27, 2024
924ef21
Remove dependencies
SantosGuillamot Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/customize-widgets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"@wordpress/core-data": "*",
"@wordpress/data": "*",
"@wordpress/dom": "*",
"@wordpress/editor": "*",
"@wordpress/element": "*",
"@wordpress/hooks": "*",
"@wordpress/i18n": "*",
Expand Down
5 changes: 0 additions & 5 deletions packages/customize-widgets/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
store as blocksStore,
} from '@wordpress/blocks';
import { dispatch } from '@wordpress/data';
import { privateApis as editorPrivateApis } from '@wordpress/editor';
import { store as preferencesStore } from '@wordpress/preferences';

/**
Expand All @@ -27,7 +26,6 @@ import CustomizeWidgets from './components/customize-widgets';
import getSidebarSection from './controls/sidebar-section';
import getSidebarControl from './controls/sidebar-control';
import './filters';
import { unlock } from './lock-unlock';

const { wp } = window;

Expand All @@ -39,8 +37,6 @@ const DISABLED_BLOCKS = [
];
const ENABLE_EXPERIMENTAL_FSE_BLOCKS = false;

const { registerCoreBlockBindingsSources } = unlock( editorPrivateApis );

/**
* Initializes the widgets block editor in the customizer.
*
Expand All @@ -64,7 +60,6 @@ export function initialize( editorName, blockEditorSettings ) {
);
} );
registerCoreBlocks( coreBlocks );
registerCoreBlockBindingsSources();
registerLegacyWidgetBlock();
if ( globalThis.IS_GUTENBERG_PLUGIN ) {
__experimentalRegisterExperimentalCoreBlocks( {
Expand Down
1 change: 0 additions & 1 deletion packages/edit-widgets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"@wordpress/data": "*",
"@wordpress/deprecated": "*",
"@wordpress/dom": "*",
"@wordpress/editor": "*",
"@wordpress/element": "*",
"@wordpress/hooks": "*",
"@wordpress/i18n": "*",
Expand Down
5 changes: 0 additions & 5 deletions packages/edit-widgets/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
} from '@wordpress/blocks';
import { dispatch } from '@wordpress/data';
import deprecated from '@wordpress/deprecated';
import { privateApis as editorPrivateApis } from '@wordpress/editor';
import { StrictMode, createRoot } from '@wordpress/element';
import {
registerCoreBlocks,
Expand All @@ -30,7 +29,6 @@ import { store as preferencesStore } from '@wordpress/preferences';
import './store';
import './filters';
import * as widgetArea from './blocks/widget-area';
import { unlock } from './lock-unlock';
import Layout from './components/layout';
import {
ALLOW_REUSABLE_BLOCKS,
Expand All @@ -44,8 +42,6 @@ const disabledBlocks = [
...( ALLOW_REUSABLE_BLOCKS ? [] : [ 'core/block' ] ),
];

const { registerCoreBlockBindingsSources } = unlock( editorPrivateApis );

/**
* Initializes the block editor in the widgets screen.
*
Expand Down Expand Up @@ -75,7 +71,6 @@ export function initializeEditor( id, settings ) {

dispatch( blocksStore ).reapplyBlockTypeFilters();
registerCoreBlocks( coreBlocks );
registerCoreBlockBindingsSources();
registerLegacyWidgetBlock();
if ( globalThis.IS_GUTENBERG_PLUGIN ) {
__experimentalRegisterExperimentalCoreBlocks( {
Expand Down
Loading