Block Bindings: Remove client core sources registration in widgets #67349
+0
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
requested review from
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
added
[Type] Bug
6 tasks
|
Size Change: -59 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Nov 27, 2024
6 tasks
SantosGuillamot
deleted the
fix/remove-client-side-bindings-in-widgets
branch
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
…ordPress#67349) * Remove client core sources registration in widgets * Remove dependencies Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: youknowriad <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
…67349) * Remove client core sources registration in widgets * Remove dependencies Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Potential fix for #67333.
It removes the client-side registration of core sources in widgets screens. As discussed in the original issue, I think it is okay to keep support only in the server for these use cases.
Why?
It seems the
@wordpress/editorpackage shouldn't be imported inedit-widgetsandcustomize-widgetspackages.How?
I just removed the function to register core sources in the editor from the widgets screen.
Testing Instructions
Go through the testing instructions in the original issue and check it is solved.