TypeScript: Convert factory utils in data package to TS #66746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
manzoorwanijk
commented
Nov 5, 2024
Comment on lines
-59
to
+64
| ( state: State, kind: string, name: string, ids: string[] ) => { | ||
| ( | ||
| state: State, | ||
| kind: string, | ||
| name: string, | ||
| ids: string | string[] | ||
| ) => { |
There was a problem hiding this comment.
The types for createRegistrySelector caught this error.
tyxla
added
[Type] Code Quality
tyxla
requested review from
adamziel,
youknowriad,
jsnajdr,
gziolo,
ellatrix,
tyxla and
sirreal
…tory.js-in-data-package-to-TS
manzoorwanijk
commented
Nov 6, 2024
Comment on lines
-6
to
-9
| * | ||
| * @param {Function} selector Selector function that calculates a value from state and parameters. | ||
| * @param {Function} getDependants Function that returns an array of "dependant" objects. | ||
| * @return {Function} A memoized version of `selector` that caches the calculated return values. |
There was a problem hiding this comment.
rememo has enough description for the params and return type.
manzoorwanijk
force-pushed
the
update/convert-factory.js-in-data-package-to-TS
branch
from
4a63582 to
2514dbb
Compare
|
@jsnajdr any feedback on this one? |
|
Moved to #67667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR converts the factory utility functions in the data package to TS:
createSelectorcreateRegistrySelectorcreateRegistryControlWhy?
To enhance the DX
How?
By renaming the files to TS and updating the types
Testing Instructions
Just verify that CI is happy
Testing Instructions for Keyboard
Screenshots or screencast