TypeScript: Convert factory utils in data package to TS #67667
Merged
+30
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7a6106b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12195704141
|
7 tasks
justlevine
reviewed
Dec 6, 2024
tyxla
reviewed
Dec 9, 2024
tyxla
approved these changes
Dec 9, 2024
manzoorwanijk
deleted the
update/convert-factory.js-in-data-package-to-TS
branch
Mamaduka
reviewed
Dec 9, 2024
| @@ -92,7 +92,7 @@ export function getEntityRecordPermissions( | |||
| name: string, | |||
| id: string | |||
| ) { | |||
| return getEntityRecordsPermissions( state, kind, name, id )[ 0 ]; | |||
| return getEntityRecordsPermissions( state, kind, name, [ id ] )[ 0 ]; | |||
There was a problem hiding this comment.
We need to update the getEntityRecordsPermissions types instead of changing the passed argument. It accepts string|string[].
I know it's a bit odd, but that's due to the limitations of memoized selectors. Current change regresses #64091.
Screenshot
There was a problem hiding this comment.
I had done exactly that here #67667 (comment)
There was a problem hiding this comment.
I'll create a follow up PR to address that. Thanks.
There was a problem hiding this comment.
manzoorwanijk
added a commit
that referenced
this pull request
Dec 10, 2024
Mamaduka
added a commit
that referenced
this pull request
Dec 10, 2024
…67770) * Update getEntityRecordsPermissions signature to allow string ids * Fix regression caused in #67667 Co-authored-by: manzoorwanijk <[email protected]> Co-authored-by: Mamaduka <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…s#67667 (WordPress#67770) * Update getEntityRecordsPermissions signature to allow string ids * Fix regression caused in WordPress#67667 Co-authored-by: manzoorwanijk <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #66746, which got closed after I deleted my fork 🤦
What?
This PR converts the factory utility functions in the data package to TS:
createSelectorcreateRegistrySelectorcreateRegistryControlWhy?
To enhance the DX
How?
By renaming the files to TS and updating the types
Testing Instructions
Just verify that CI is happy
Testing Instructions for Keyboard
Screenshots or screencast