PostTaxonomiesFlatTermSelector: abstract wrapper component #66625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refore, blur/clearing tag control
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +8 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Thanks for the quick fix! |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 31, 2024
Co-authored-by: ramonjd <[email protected]> Co-authored-by: kevin940726 <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 665997f |
This was referenced Oct 31, 2024
|
Thanks for fixing this, @ramonjd and @kevin940726! Side note: We need to stabilize the e2e test runner and reporter. Otherwise, the genuine regressions can be (and are) ignored with the current report rate. |
|
Thank you for the quick fix! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#66625) Co-authored-by: ramonjd <[email protected]> Co-authored-by: kevin940726 <[email protected]>
priethor
added
the
Backport to Gutenberg Minor Release
priethor
pushed a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: ramonjd <[email protected]> Co-authored-by: kevin940726 <[email protected]>
|
I just cherry-picked this PR to the release/19.6 branch to get it included in the next release: bec138a |
priethor
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to:
Noticed by me and @kevin940726 while testing WordPress/wordpress-develop#7693
Props to @kevin940726 for working out the culprit
Why?
The controls appears to rerender when adding a tag, or at least, it loses focus.
2024-10-31.13.01.59.mp4
How?
Extract Wrapper into an external component to avoid rerender, and therefore, blur/clearing tag control.
Testing Instructions
Kapture.2024-10-31.at.13.11.03.mp4