-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "pull request automation use regular npm install" #66447
Backport "pull request automation use regular npm install" #66447
Conversation
Remove single-package installation from this workflow that creates problems when migrating to npm workspaces. The regular npm install workflow is frequently available in cache. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> # Conflicts: # .github/workflows/pull-request-automation.yml
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me 👍
Other release branches may experience the same issue.
This workflow was fragile because it was effectively configured on one commit in a way that relied on the state of the repo in another commit. This change should make it less fragile.
Strange. That error on CI is exactly what was observed previously that was fixed by the same change in #66314. I'll investigate soon… |
The failing workflow is running on the
That is, the workflow is still the old one on |
Good spot @kevin940726, that would explain why this fix didn't work on the branch 🙂 I maintain that this change should be merged to |
This was tested with #66457 and it seemed to work correctly. |
What?
Backport of #66314.
Why?
Because CI is failing
npm install
on thewp/6.7
branch.See discussion in WP Slack https://wordpress.slack.com/archives/C02QB2JS7/p1729680379803689.
How?
Manual backport.
Testing Instructions
Deferring to @sirreal to double check this makes sense.
Testing Instructions for Keyboard
Screenshots or screencast