-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request automation: use full npm install #66314
Pull request automation: use full npm install #66314
Conversation
This is likely to be cached and creates fewer problems with installing a specific workspace and patch package.
This reverts commit 4b3f016.
The job on this branch reuses a cache and completes in a reasonable amount of time. It just took 37s. It doesn't appear significantly slower than other recent runs. They range from 17s to 32s. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Backporting this on advice from @sirreal in relation to failing CI on the |
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk.
|
Ok then...I'll do this by hand. |
Remove single-package installation from this workflow that creates problems when migrating to npm workspaces. The regular npm install workflow is frequently available in cache. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> # Conflicts: # .github/workflows/pull-request-automation.yml
Remove single-package installation from this workflow that creates problems when migrating to npm workspaces. The regular npm install workflow is frequently available in cache. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: kevin940726 <[email protected]>
Manually backported in #66447 |
Remove single-package installation from this workflow that creates problems when migrating to npm workspaces. The regular npm install workflow is frequently available in cache. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]>
What?
Use full npm install for the pull-request-automation workflow.
This installation is larger and slower, however I suspect that is likely to be offset by caching.
This is also blocking work on the migration to npm workspaces that has its own merits in #66272.
Why?
The pull-request-automation workflow creates problems when migrating to npm workspaces:
https://github.com/WordPress/gutenberg/actions/runs/11435991643/job/31813748278
Extracted from #66272.
How?
Use the regular npm installation flows shared by other github actions in the project.
Testing Instructions
CI passes. pull-request-automation workflow runs as expected.