-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.screen-reader-text CSS update for responsive-block-control style.scss #66145
.screen-reader-text CSS update for responsive-block-control style.scss #66145
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mediaformat! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Couple questions:
|
Yes I think that component is probably due to be removed or deprecated. Not sure it's used. |
Co-authored-by: mediaformat <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: getdave <[email protected]>
What?
Addresses part of #65954
Why?
The utility .screen-reader-text CSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.
How?
Remove the unnecessary
clip: rect(1px, 1px, 1px, 1px);
rule from thepackages/block-editor/src/components/responsive-block-control/style.scss
Style attribute