Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.screen-reader-text CSS update for responsive-block-control style.scss #66145

Conversation

mediaformat
Copy link
Contributor

@mediaformat mediaformat commented Oct 15, 2024

What?

Addresses part of #65954

Why?

The utility .screen-reader-text CSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.

How?

Remove the unnecessary clip: rect(1px, 1px, 1px, 1px); rule from the packages/block-editor/src/components/responsive-block-control/style.scss

Style attribute

Before After
Screenshot 2024-09-17 at 17 48 21 Screenshot 2024-09-17 at 17 48 57

Copy link

github-actions bot commented Oct 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mediaformat <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 15, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mediaformat! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@colorful-tones colorful-tones added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Code Quality Issues or PRs that relate to code quality labels Oct 15, 2024
@mediaformat mediaformat changed the title Remove clip for screen-reader-text CSS .screen-reader-text CSS update for responsive-block-control style.css Oct 15, 2024
@mediaformat mediaformat changed the title .screen-reader-text CSS update for responsive-block-control style.css .screen-reader-text CSS update for responsive-block-control style.scss Oct 15, 2024
@afercia
Copy link
Contributor

afercia commented Oct 16, 2024

Couple questions:

@getdave
Copy link
Contributor

getdave commented Oct 16, 2024

Yes I think that component is probably due to be removed or deprecated. Not sure it's used.

@afercia afercia merged commit 5c18dc7 into WordPress:trunk Oct 16, 2024
71 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.5 milestone Oct 16, 2024
@mediaformat mediaformat deleted the update/screen-reader-css-responsive-block-control-style-scss branch October 16, 2024 15:31
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Co-authored-by: mediaformat <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: getdave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants