Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Remove redundant styles #65409

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

A11y: Remove redundant styles #65409

wants to merge 3 commits into from
+20 −24

Commits on Sep 17, 2024

  1. Remove redundant CSS styles and spaces

    @sirreal
    sirreal committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e6db5df View commit details
    Browse the repository at this point in the history

  2. Improve container ariaLive parameter type

    @sirreal
    sirreal committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    62ad427 View commit details
    Browse the repository at this point in the history

  3. Use empty string to set boolean attribute 

    This is a minimal way of setting the `hidden` attribute.

From MDN:

> The hidden attribute is used to indicate that the content of an element should not be presented to the user. This attribute can take any one of the following values:
>
> - an empty string
> - the keyword hidden
> - the keyword until-found
>
> An empty string, or the keyword hidden, set the element to the hidden state. Additionally, invalid values set the element to the hidden state.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
    @sirreal
    sirreal committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ab79786 View commit details
    Browse the repository at this point in the history