Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image block margins for RTL in editor #65249

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sabernhardt
Copy link
Contributor

Follow-up to #47617 (issue #44845)

What?

Adds /*rtl:ignore*/ comments to adjust the left and right margins of the Image block for RTL languages.

Why?

  • Prevent nearby text from touching the image.
  • Match the front.

Testing Instructions

  1. Set the Site Language (and/or your profile language) to a right-to-left language.
  2. Activate Twenty Sixteen.
  3. Open the post editor.
  4. Add an Image block with a small image.
  5. Set the Image block's alignment to Align left.
  6. Add a Paragraph block immediately following the image.
  7. Create a similar Image block, aligned right, and follow that with another paragraph.
  8. Resize the viewport (or editor canvas) to confirm that the paragraph text does not touch the image at any screen width.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sabernhardt <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants