Image: Update image block margins on RTL #47617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.32 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e7ac89c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4121181088
|
aristath
approved these changes
Feb 8, 2023
DaisyOlsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds two additional
/*rtl:ignore*/to adjust the margin of the image block on RTL.Closes #44845
Credit to @sabernhardt
Why?
In RTL languages, image blocks that are aligned to the left or right can touch the text, because the margin that is intended to prevent this, is on the incorrect side of the image.
Testing Instructions
Screenshots or screencast
After, left aligned image has right margin:
After, right aligned image has left margin:
