Global Styles: Don't apply the background and text colors to typography previews #62578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +31 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in edba2df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9515643420
|
ajlende
approved these changes
Jun 14, 2024
scruffian
added
the
Backport to WP 6.7 Beta/RC
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…hy previews (WordPress#62578) Co-authored-by: scruffian <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: hbhalodia <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
…hy previews (#62578) Co-authored-by: scruffian <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: hbhalodia <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 0cc07d4 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
…hy previews (#62578) Co-authored-by: scruffian <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: hbhalodia <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix #61217. Alternative to #61898.
Removes all style rules from color and typography variation previews, except the for the property that is in the preset.
Why?
The typography presets only change typography styles so it makes sense to keep these preview clear of any other settings.
How?
Pass the property that we are previewing to the variation component as a prop. If present we use this prop to filter out only this style so it can be used in the preview.
Testing Instructions
Testing Instructions for Keyboard
This is a visual change.
Screenshots or screencast