Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove color styles from typography variation controls #61217

Closed
richtabor opened this issue Apr 29, 2024 · 2 comments · Fixed by #62578
Closed

Remove color styles from typography variation controls #61217

richtabor opened this issue Apr 29, 2024 · 2 comments · Fixed by #62578
Assignees
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

Currently typography variations have the active theme’s styles applied to the controls.

Let’s instead not apply those colors, but only the typography styles—making these controls feel more integrated with the rest of the UI, potentially reducing confusion. These don't need the colors to communicate the typography values, and may be confused with full style variations (which do include color and typography styles).

Visual

CleanShot 2024-04-29 at 15 39 33
CleanShot 2024-04-29 at 15 41 58

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Theme Style Variations Related to style variations provided by block themes labels Apr 29, 2024
hbhalodia added a commit to hbhalodia/gutenberg that referenced this issue May 1, 2024
This would fix the issue added in WordPress#61217, This wanted to remove the color combination in the typography preview shown in the styles editor page
@hbhalodia
Copy link
Contributor

Hello @richtabor, I just have a quick question here, We do have the typography options on the left side panel, while selecting the style's variation. Should also we remove the color from that as well, or should we keep the color to align it with the current style being added and just remove it from the typography section? Below is the screenshot I am talking about.

Screenshot 2024-05-01 at 4 47 12 PM

Although, I have raised the PR for the same - #61280. This PR includes the color for the above issue mentioned, if we need to remove from that, I would update the PR.

Thank You.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 23, 2024
@draganescu draganescu added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels May 29, 2024
@draganescu
Copy link
Contributor

I would consider this a visual bug, not an enhancement. The styling make the actual variations less accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
4 participants