Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : Update alt text decision tree links to be translatable #62076

Merged
merged 5 commits into from
May 30, 2024
Merged

Fixed : Update alt text decision tree links to be translatable #62076

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98b2a4d
Implemented: Update alt text decision tree links to be translatable
narenin May 28, 2024
6476016
Implemented: Update alt text decision tree links to be translatable
narenin May 28, 2024
2334846
Implemented Suggestions
narenin May 29, 2024
c946e37
Implemented comment related changes
narenin May 29, 2024
a82d7c2
Resolved Conflict
narenin May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/block-library/src/cover/edit/inspector-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,14 @@ export default function CoverInspectorControls( {
}
help={
<>
<ExternalLink href="https://www.w3.org/WAI/tutorials/images/decision-tree">
<ExternalLink
href={
// translators: Localized tutorial, if one exists. Link includes list of existing translations.
__(
joedolson marked this conversation as resolved.
Show resolved Hide resolved
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
>
{ __(
'Describe the purpose of the image.'
) }
Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/image/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,10 @@ export class ImageEdit extends Component {
) }{ ' ' }
<FooterMessageLink
href={
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
// translators: Localized tutorial, if one exists. Link includes list of existing translations.
__(
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
value={ __( 'What is alt text?' ) }
/>
Expand Down
18 changes: 16 additions & 2 deletions packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,14 @@ export default function Image( {
<>{ lockAltControlsMessage }</>
) : (
<>
<ExternalLink href="https://www.w3.org/WAI/tutorials/images/decision-tree">
<ExternalLink
href={
// translators: Localized tutorial, if one exists. Link includes list of existing translations.
__(
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
>
{ __(
'Describe the purpose of the image.'
) }
Expand Down Expand Up @@ -684,7 +691,14 @@ export default function Image( {
<>{ lockAltControlsMessage }</>
) : (
<>
<ExternalLink href="https://www.w3.org/WAI/tutorials/images/decision-tree">
<ExternalLink
href={
// translators: Localized tutorial, if one exists. Link includes list of existing translations.
__(
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
>
{ __(
'Describe the purpose of the image.'
) }
Expand Down
9 changes: 8 additions & 1 deletion packages/block-library/src/media-text/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,14 @@ function MediaTextEdit( {
onChange={ onMediaAltChange }
help={
<>
<ExternalLink href="https://www.w3.org/WAI/tutorials/images/decision-tree">
<ExternalLink
href={
// translators: Localized tutorial, if one exists. Link includes list of existing translations.
__(
'https://www.w3.org/WAI/tutorials/images/decision-tree/'
)
}
>
{ __(
'Describe the purpose of the image.'
) }
Expand Down
Loading