Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed : Update alt text decision tree links to be translatable #62076

Merged
merged 5 commits into from
May 30, 2024
Merged

Fixed : Update alt text decision tree links to be translatable #62076

merged 5 commits into from
May 30, 2024

Conversation

narenin
Copy link
Contributor

@narenin narenin commented May 28, 2024

Fixes a bug raised here #62038

What?

Updated alt text decision tree links to be translatable.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: narenin <[email protected]>
Co-authored-by: joedolson <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 28, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @narenin! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@narenin narenin mentioned this pull request May 28, 2024
Closed
@michalczaplinski michalczaplinski added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library labels May 28, 2024
@michalczaplinski
Copy link
Contributor

michalczaplinski commented May 28, 2024 •
edited
Loading

Thank you form working on this @narenin !

This seems fine to me but perhaps @joedolson would like to confirm?

@joedolson
Copy link
Contributor

These links should have translator comments to provide context for the link. In the related core patch, you can see an example of the comment in core.

@narenin
Copy link
Contributor Author

narenin commented May 29, 2024

@joedolson I have implemented the suggestions, could you please check.

@michalczaplinski michalczaplinski removed their request for review May 29, 2024 09:41
joedolson
joedolson requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comment text change; applies to all files.

packages/block-library/src/cover/edit/inspector-controls.js Show resolved Hide resolved
joedolson
joedolson approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @narenin!

@t-hamano
Copy link
Contributor

@narenin

It seems there is a conflict in one file, so could you resolve that conflict? Also, GitHub Actions should be stable on the latest trunk, so I would appreciate it if you could rebase your PR again.

Thank you!

@narenin
Copy link
Contributor Author

narenin commented May 30, 2024

@t-hamano Thanks for the feedback. I have resolved the conflict, please have a look.

@t-hamano t-hamano self-requested a review May 30, 2024 11:42
t-hamano
t-hamano approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narenin Thanks for the update!

@t-hamano t-hamano merged commit ee3d1ea into WordPress:trunk May 30, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 30, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
@narenin @joedolson
@michalczaplinski @t-hamano @carstingaxion
Fixed : Update alt text decision tree links to be translatable (Wor…
289ab7b 
…dPress#62076)

* Implemented: Update alt text decision tree links to be translatable

* Implemented: Update alt text decision tree links to be translatable

* Implemented Suggestions

* Implemented comment related changes

Co-authored-by: narenin <[email protected]>
Co-authored-by: joedolson <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: t-hamano <[email protected]>
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@narenin @joedolson
@michalczaplinski @t-hamano @patil-vipul
Fixed : Update alt text decision tree links to be translatable (Wor…
384dae7 
…dPress#62076)

* Implemented: Update alt text decision tree links to be translatable

* Implemented: Update alt text decision tree links to be translatable

* Implemented Suggestions

* Implemented comment related changes

Co-authored-by: narenin <[email protected]>
Co-authored-by: joedolson <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@joedolson joedolson joedolson approved these changes

@artemiomorales artemiomorales Awaiting requested review from artemiomorales artemiomorales is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 18.5
Development

Successfully merging this pull request may close these issues.
4 participants
@narenin @michalczaplinski @joedolson @t-hamano