Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Playwright to v1.45 #61443

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Upgrade Playwright to v1.45 #61443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b70c863
Upgrade Playwright to v1.44
Mamaduka May 7, 2024
cbecdbb
Use new accessibility assertions
Mamaduka May 7, 2024
1969893
Bump to latest
Mamaduka May 31, 2024
79c3a63
Bump to v1.45
Mamaduka Jun 26, 2024
ebb1710
Bump to v1.45.1
Mamaduka Jul 5, 2024
9687518
Skip failing RichText tests on Firefox
Mamaduka Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"@octokit/rest": "16.26.0",
"@octokit/types": "6.34.0",
"@octokit/webhooks-types": "5.8.0",
"@playwright/test": "1.43.0",
"@playwright/test": "1.45.1",
"@pmmmwh/react-refresh-webpack-plugin": "0.5.11",
"@react-native/babel-preset": "0.73.10",
"@react-native/metro-babel-transformer": "0.73.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"webpack-dev-server": "^4.15.1"
},
"peerDependencies": {
"@playwright/test": "^1.43.0",
"@playwright/test": "^1.45.1",
"react": "^18.0.0",
"react-dom": "^18.0.0"
},
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/specs/editor/various/rich-text.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ test.describe( 'RichText (@firefox, @webkit)', () => {
expect( count ).toBe( 1 );
} );

test( 'should return focus when pressing formatting button', async ( {
test( 'should return focus when pressing formatting button (-firefox)', async ( {
page,
editor,
} ) => {
Expand Down Expand Up @@ -415,7 +415,7 @@ test.describe( 'RichText (@firefox, @webkit)', () => {
] );
} );

test( 'should update internal selection after fresh focus', async ( {
test( 'should update internal selection after fresh focus (-firefox)', async ( {
page,
editor,
pageUtils,
Expand Down
8 changes: 3 additions & 5 deletions test/e2e/specs/site-editor/navigation-editor.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,9 @@ test.describe( 'Editing Navigation Menus', () => {
await expect( navBlockNode ).toBeVisible();

// The Navigation block description should contain the locked state information.
const navBlockNodeDescriptionId =
await navBlockNode.getAttribute( 'aria-describedby' );
await expect(
listView.locator( `id=${ navBlockNodeDescriptionId }` )
).toHaveText( /This block is locked./ );
await expect( navBlockNode ).toHaveAccessibleDescription(
/This block is locked./
);
Comment on lines +65 to +67
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afercia, I think you'll like the new a11y assertions - https://github.com/microsoft/playwright/releases/tag/v1.44.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhu, thanks for pointing me at it 🥳


// The block should have no options menu.
await expect(
Expand Down
Loading