Upgrade Playwright to v1.45 #61443
Merged
Upgrade Playwright to v1.45 #61443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
swissspidy,
WunderBart and
kevin940726
and removed request for
ntwb,
ajitbohra,
ryanwelcher and
nerrad
Mamaduka
commented
May 7, 2024
Comment on lines
+65
to
+67
| await expect( navBlockNode ).toHaveAccessibleDescription( | ||
| /This block is locked./ | ||
| ); |
There was a problem hiding this comment.
@afercia, I think you'll like the new a11y assertions - https://github.com/microsoft/playwright/releases/tag/v1.44.0
There was a problem hiding this comment.
Uhu, thanks for pointing me at it 🥳
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
May 7, 2024
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
a516c99 to
5910db3
Compare
|
The RichText e2e tests seem to be failing on Firefox after the upgrade. I couldn't reproduce them manually, but I will continue debugging tomorrow. |
|
Some of the |
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
5910db3 to
4cb1608
Compare
@Mamaduka, I'm wondering if we should use |
|
@WunderBart, do you think there are changes in |
I'm not sure, but considering that |
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
4cb1608 to
bf80573
Compare
|
The same failures remain after the latest update; there might be an actual bug with Firefox and RichText. I'll try to debug it later.
@WunderBart, I don't think we can use |
Mamaduka
force-pushed
the
update/playwright-latest
branch
2 times, most recently
from
1ea26b9 to
52d459a
Compare
|
@ellatrix, I'm thinking to skip this two failing RichText e2e tests on Firefox.
|
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
52d459a to
9687518
Compare
|
Sure let's skip Firefox for these two |
scruffian
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Upgrade Playwright to v1.44 * Use new accessibility assertions * Bump to latest * Bump to v1.45 * Bump to v1.45.1 * Skip failing RichText tests on Firefox Co-authored-by: Mamaduka <[email protected]> Co-authored-by: swissspidy <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: WunderBart <[email protected]> Co-authored-by: ellatrix <[email protected]>
2 tasks
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Upgrade Playwright to v1.44 * Use new accessibility assertions * Bump to latest * Bump to v1.45 * Bump to v1.45.1 * Skip failing RichText tests on Firefox Co-authored-by: Mamaduka <[email protected]> Co-authored-by: swissspidy <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: WunderBart <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade Playwright to v1.45
What's new?
https://github.com/microsoft/playwright/releases/tag/v1.44.0
https://github.com/microsoft/playwright/releases/tag/v1.45.0
Testing Instructions