-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextareaControl: Remove extra closing curly brace in inputStyleNeutral
#59744
Conversation
…eNeutral' CSS component
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SahilThakur02! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Fixes #59529 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@annaghi @ajitbohra How will my PR get merged? as it have been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
For posterity, this code change affects the TextareaControl
component, rather than the Heading block as mentioned in the testing instructions. You can find this by looking up where inputStyleNeutral
is referenced in the codebase, and going up the chain until you hit a component. Then, you can run npm run storybook:dev
to spin up the Storybook, and test any changes to the TextareaControl component. I've tested it this way and confirmed that it works as expected 👍
And don't worry, one of us will merge this PR for you. Please take a look at this comment to link your GitHub and WordPress.org accounts so we can properly credit you on this contribution. Thanks!
inputStyleNeutral
Linked my Github with Wordpress aswell @mirka @annaghi @ajitbohra |
…al` (WordPress#59744) Co-authored-by: SahilThakur02 <[email protected]> Co-authored-by: ajitbohra <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: annaghi <[email protected]>
Fixed Syntax Error in CSS Component
Hello Gutenberg Contributors!
I'm excited to present my contribution to the project with this pull request. In this PR, I addressed a syntax error that was affecting the 'inputStyleNeutral' CSS component. By removing an extra curly brace, I ensured the proper functioning of this component.
What?
The primary focus of this PR was to fix the syntax error in the 'inputStyleNeutral' CSS component.
Why?
This fix was necessary to maintain the integrity and functionality of the CSS component within Gutenberg.
How?
To resolve the issue, I carefully reviewed the code and removed the unnecessary curly brace in the 'inputStyleNeutral' CSS component.
Testing Instructions
I have provided step-by-step instructions for testing this PR:
Additionally, for keyboard accessibility testing:
Your feedback and review of this contribution are highly appreciated. Together, we can continue to improve Gutenberg for the WordPress community!