Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error: Extra closing curly brace in 'inputStyleNeutral' CSS component #59529

Closed
annaghi opened this issue Mar 3, 2024 · 5 comments
Closed
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality

Comments

@annaghi
Copy link

annaghi commented Mar 3, 2024

Description

The CSS border property incorrectly includes an extra closing curly brace.

Incorrect syntax:
border: ${ CONFIG.borderWidth } solid ${ COLORS.ui.border } };

Correct syntax:
border: ${ CONFIG.borderWidth } solid ${ COLORS.ui.border };

Step-by-step reproduction instructions

Navigate to packages/components/src/utils/input/base.js and locate the inputStyleNeutral component:

export const inputStyleNeutral = css`
	box-shadow: 0 0 0 transparent;
	transition: box-shadow 0.1s linear;
	border-radius: ${ CONFIG.radiusBlockUi };
	border: ${ CONFIG.borderWidth } solid ${ COLORS.ui.border } };    <----- extra '}' at the end
	${ reduceMotion( 'transition' ) }
`;

Visit https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/utils/input/base.js#L17

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annaghi annaghi added the [Type] Bug An existing feature does not function as intended label Mar 3, 2024
@colorful-tones colorful-tones added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality labels Mar 3, 2024
@ShubhamPatilsd
Copy link

Our students (beginners) at https://labs.codeday.org will be taking a go at this in the coming week :)

@SahilThakur02
Copy link
Contributor

@annaghi can I start working on it?

@annaghi
Copy link
Author

annaghi commented Mar 10, 2024

@ShubhamPatilsd Have you (or your students) started to work on this issue? @SahilThakur02 is also offering help.

@oceantober
Copy link

My team and I from Code Day are working on this issue! We will be starting this week.

@mirka
Copy link
Member

mirka commented Mar 19, 2024

Closed by #59744

@mirka mirka closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

6 participants