Editor: Reuse data query in the post author components #58760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -50 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Feb 7, 2024
| return { | ||
| authorId: _authorId, | ||
| authors: getUsers( query ), | ||
| postAuthor: getUser( _authorId, BASE_QUERY ), |
There was a problem hiding this comment.
The query argument must have a stable reference for getEntityRecord to return the memoized value. The issue is more noticeable when passing the _fields argument - the selector will return a new reference on each call.
cc @youknowriad
Unit Test
it( 'should return same reference for filtered item', () => {
const state = deepFreeze( {
entities: {
records: {
postType: {
post: {
queriedData: {
items: {
default: {
1: {
id: 1,
content: 'chicken',
author: 'bob',
},
},
},
itemIsComplete: {
default: {
1: true,
},
},
queries: {},
},
},
},
},
},
} );
expect(
getEntityRecord( state, 'postType', 'post', 1, {
_fields: 'author,content',
} )
).toBe(
getEntityRecord( state, 'postType', 'post', 1, {
_fields: 'author,content',
} )
);
} );
|
Flaky tests detected in a224673. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7809872420
|
youknowriad
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PRs introduces a new
useAuthorsQueryhook and reuses it across the components.Why?
Maintenance.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast