Memoize entity records selectors properly #34323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +53 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
perf/improve-entity-record-selectors
branch
from
ea004e9 to
2efca42
Compare
youknowriad
force-pushed
the
perf/improve-entity-record-selectors
branch
from
2efca42 to
592073b
Compare
ellatrix
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #32106
the current getTemplate selector calls in the
Editorcomponent are causing the rerendering of the whole editor while typing, this should improve it. I'm not sure whether this will have an impact on the "typing" metric but personally I did notice some calls in the trace related to this.