Site editor: add margin to entity save panel header via a classname #57473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed to additionalPrompt
ramonjd
added
[Type] Task
|
Size Change: +15 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and how?
Follow up to:
Use a classname instead of the element on the "Are you ready to save?" element in the save flow to add bottom margin.
Why?
As @andrewserong points out, it's a better way to guard against possible regressions in case a strong element is passed to
additionalPrompt.Testing Instructions
Test instructions copied from #57471
Testing Instructions for Keyboard
Screenshots or screencast
Before
2024-01-02.12.52.35.mp4
After
2024-01-02.12.51.22.mp4