Site editor: add padding to entity save panel header #57471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +23 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Good catch!
| Before | After |
|---|---|
 |
 |
Is there a chance anyone might include a strong tag within additionalPrompt? If so, we could always use a child combinator so that the rule is > strong, or add a classname to the strong tag and use that instead?
Given that the component is private for now and that the only current usage of additionalPrompt is for the theme prompt as you've mentioned, this change seems fine to me for now.
LGTM! ✨
|
Wow, that was fast. Thank you! |
Oh dang, I just digested this. It's possible yeah. I already merged, but I think a className on the strong tag would be a better, long-term solution. I'll create another one 😄 |
No harm done! Thanks for following up 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and how?
Like it says on the box, add some padding to the "Are you ready to save?" save panel header.
Why?
In the absence of any
additionalPromptcontent, when you deselect all entities to save, the header sits too close to the panel border below.The only
additionalPromptcontent I could find is a p tag that is shown when previewing a new theme in the site editor. This content has its own, default padding of1em.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
2024-01-02.12.52.35.mp4
After
2024-01-02.12.51.22.mp4